Make sure crates not opting in to staged_api don't use staged_api #44008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Also, looks like at least [00:28:14] Compiling rustc_plugin v0.0.0 (file:///checkout/src/librustc_plugin)
[00:28:14] error: stability attributes may not be used outside of the standard library
[00:28:14] --> /checkout/src/librustc_plugin/registry.rs:129:5
[00:28:14] |
[00:28:14] 129 | #[unstable(feature = "rustc_private", issue = "27812")]
[00:28:14] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:28:14]
[00:28:14] error: stability attributes may not be used outside of the standard library
[00:28:14] --> /checkout/src/librustc_plugin/registry.rs:130:5
[00:28:14] |
[00:28:14] 130 | #[rustc_deprecated(since = "1.15.0", reason = "replaced by macros 1.1 (RFC 1861)")]
[00:28:14] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:28:14]
[00:28:15] error: aborting due to 2 previous errors |
|
@bors: r+ Thanks! |
|
📌 Commit 472e7e3 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 22, 2017
Make sure crates not opting in to staged_api don't use staged_api This also fixes the problem that with `-Zforce-unstable-if-unmarked` set, crates could not use `#[deprecated]`. If you prefer, I can instead submit another version which just fixes this problem, but still allows the staged API attributes for all crates when `-Zforce-unstable-if-unmarked` is set. I have prepared that at <https://github.com/RalfJung/rust/tree/staged2>. As yet another alternative, @alexcrichton suggested to turn this error into a lint, but that seems to be much more work, so is it worth it? Cc @alexcrichton #43975
|
☀️ Test successful - status-appveyor, status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the problem that with
-Zforce-unstable-if-unmarkedset, crates could not use#[deprecated].If you prefer, I can instead submit another version which just fixes this problem, but still allows the staged API attributes for all crates when
-Zforce-unstable-if-unmarkedis set. I have prepared that at https://github.com/RalfJung/rust/tree/staged2. As yet another alternative, @alexcrichton suggested to turn this error into a lint, but that seems to be much more work, so is it worth it?Cc @alexcrichton #43975